Skip to content

2170 — Equipment response power fields: int → float

Problem

equipment_factors.csv moved active_power_w / standby_power_w from int to float (data-description doc, Equipment section) ~4 weeks before this fix. EquipmentFactorCreate / Update / Response were updated at the time; EquipmentHandlerResponse in app/modules/equipment/data_entries.py was not. Any data entry enriched with a fractional factor value 500s at to_response() — reproduced in stage on entry id=385685 (standby_power_w=2.368421053).

Fix

Two-field type change, int | None → float | None, on EquipmentHandlerResponse. No other equipment DTO needed touching — the factor-side DTOs, the formula (handlers.py, already casts via float()), and the frontend (TS number, no int assumption) were already correct.

Regression

tests/unit/modules/test_equipment_schemas.py::test_equipment_response_accepts_fractional_power_w validates EquipmentHandlerResponse against the exact stage payload; confirmed failing pre-fix with the reported int_from_float error, passing post-fix.

Swept for the same bug class elsewhere

Same shape of bug: a data-entry response DTO field fed from primary_factor.get(...) / factor_values.get(...) whose type has drifted from the factor DTO that actually owns the value.

  • Imported every module's data_entries.py + factors.py (buildings, equipment, external_cloud_and_ai, headcount, process_emissions, professional_travel, purchase, research_facilities), diffed model_fields base types (Optional/required differences excluded — legitimate) for every field name shared between a data-entry DTO and a factor DTO in the same module. Zero mismatches remain after this fix.
  • Grepped every handlers.py for primary_factor.get(...) / factor_values.get(...) written straight into a response dict, to find which response fields are factor-enriched rather than user-entered (the precondition for this bug class). Only buildings (heating_kwh_per_square_meter, cooling_kwh_per_square_meter, ventilation_kwh_per_square_meter, lighting_kwh_per_square_meter) shares this shape with equipment — already float on both sides, no fix needed.

No further PRs from this sweep.